Error In firmware (MPLS Implementation)

  • 2 Replies
  • 472 Views
*

mpls95

  • Newbie
  • *
  • 12
    • View Profile
Error In firmware (MPLS Implementation)
« on: November 28, 2018, 05:45:15 AM »
Hello!

I've been reviewing the github firmware code and I've seen that Zodiac add 2 extra bytes when pushing MPLS labels(and removing this 2 bytes when Zodiac pop labels), in the code the PUSH MPLS label (ZodiacFX / src / openflow / openflow_13.c)  increases the packet size by 6 bytes, and MPLS labels have only 4 bytes:

MPLS PACKETS MUST BE:

|ETHERNET|MPLS(4 BYTES)|IP|

and not:

|ETHERNET|MPLS(4 BYTES)|2 extra bytes of a redundance of Ethernet type of service|IP|

Can you check it Paul?


« Last Edit: December 14, 2018, 09:09:25 PM by mpls95 »

*

mpls95

  • Newbie
  • *
  • 12
    • View Profile
Re: Error In firmware (MPLS Implementation)
« Reply #1 on: November 29, 2018, 03:15:39 AM »
I have solved the problem, if you want contact me to share the code.

« Last Edit: December 14, 2018, 06:52:21 AM by mpls95 »

*

mpls95

  • Newbie
  • *
  • 12
    • View Profile
Re: Error In firmware (MPLS Implementation)
« Reply #2 on: December 18, 2018, 10:34:19 AM »
And also, stacking labels, when you assign the value of the label you overwrite the same label all the time instead of assigning a value for each label, you always write on the label closer to the ethernet header. I`ve solved too.

Greetings, encourage the project and I await your response